core: make vector foreach standard C compliant#544
Closed
MukundaKatta wants to merge 1 commit into
Closed
Conversation
Contributor
That's not how we build the project.
"I made a change to prevent a build error but didn't build the project" is not an acceptable testing plan. It's the second time you're opening a PR on this project, and it's the second time you disregard the style guide (#519). It's either a lack of human involvement or a lack of basic decency when it comes to testing the code you submit. Next time I suspect another AI-generated comment or PR from you, I'll block you. I spent more time writing this comment than you spent opening 2 PRs on this project. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #509.
Testing
Note: full CMake configuration is blocked locally because libbpf is not installed.